Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(marshal): Migrate to Endo #4384

Merged
merged 9 commits into from
Feb 1, 2022
Merged

chore(marshal): Migrate to Endo #4384

merged 9 commits into from
Feb 1, 2022

Conversation

kriskowal
Copy link
Member

This change applies my patented™ seven (maybe eight?) step system to eject a package to npm, this time to Marshal.

Refs: endojs/endo#506

@kriskowal kriskowal force-pushed the 506-migrate-marshal branch from 301af02 to e06f532 Compare January 26, 2022 00:20
@kriskowal
Copy link
Member Author

Currently blocked on endojs/endo#1021 and a publish.

@kriskowal kriskowal marked this pull request as draft January 26, 2022 01:49
@kriskowal kriskowal force-pushed the 506-migrate-marshal branch 3 times, most recently from d6e6ee8 to 7c4fd70 Compare January 29, 2022 01:56
@kriskowal kriskowal marked this pull request as ready for review January 29, 2022 02:15
@kriskowal
Copy link
Member Author

This is ready for review. The commit that includes SES patches will be replaced pending endojs/endo#1030

@kriskowal kriskowal requested a review from michaelfig January 29, 2022 02:16
michaelfig
michaelfig reviewed Jan 31, 2022
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdate merge conflicts mean that this PR needs to be redune to absorb @erights changes.

@kriskowal kriskowal mentioned this pull request Jan 31, 2022
Merged
@kriskowal kriskowal force-pushed the 506-migrate-marshal branch from 7c4fd70 to 5526820 Compare January 31, 2022 23:59
@kriskowal kriskowal requested a review from michaelfig February 1, 2022 00:11
@kriskowal
Copy link
Member Author

Removed the patches, reran the automated commits. Ready for review.

michaelfig
michaelfig approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope it's okay that I skipped over the giant sed-transform of @agoric/marshal to @endo/marshal. I couldn't bring myself to audit >500 files.

@kriskowal
Copy link
Member Author

I hope it's okay that I skipped over the giant sed-transform of @agoric/marshal to @endo/marshal. I couldn't bring myself to audit >500 files.

Yeah, I didn’t either. Let’s hope the tests have us covered.

@kriskowal kriskowal merged commit 404d270 into master Feb 1, 2022
@kriskowal kriskowal deleted the 506-migrate-marshal branch February 1, 2022 00:48
@mhofman mhofman mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelfig michaelfig michaelfig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kriskowal @michaelfig