Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep SwingSet state in the validator state dir #434

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

michaelfig
Copy link
Member

Closes #433

@michaelfig michaelfig added the cosmic-swingset package: cosmic-swingset label Jan 21, 2020
@michaelfig michaelfig requested a review from warner January 21, 2020 17:13
@michaelfig michaelfig force-pushed the 433-unsafe-reset-all branch from cc5658a to c2e90a4 Compare January 21, 2020 21:06
Closes #433

We try our best to find the actual Cosmos state directory.
@michaelfig michaelfig force-pushed the 433-unsafe-reset-all branch from c2e90a4 to 95131ce Compare January 21, 2020 21:08
Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good idea. Could you add a docs/ag-chain-cosmos.md and mention both the --flag and the environment variable as ways to control where the kernel state gets stored? There are more docs we should add soon but we can make a small start now, while we're thinking about it.

@michaelfig
Copy link
Member Author

Yeah, good idea. Could you add a docs/ag-chain-cosmos.md and mention both the --flag and the environment variable as ways to control where the kernel state gets stored? There are more docs we should add soon but we can make a small start now, while we're thinking about it.

I'll put this in the Validator Guide, for later reorganization.

@michaelfig michaelfig merged commit 00b874c into master Jan 21, 2020
@michaelfig michaelfig deleted the 433-unsafe-reset-all branch January 21, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmic-swingset package: cosmic-swingset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ag-chain-cosmos unsafe-reset-all needs to reset kernel state too
2 participants