Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update sort order so undefined comes last #4252

Merged
merged 1 commit into from
Jan 8, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/store/src/patterns/rankOrder.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ const PassStyleRankAndCover = harden([
/* np */ ['bigint', ['n', 'p~']],
/* r */ ['remotable', ['r', 'r~']],
/* s */ ['string', ['s', 't']],
/* u */ ['undefined', ['u', 'v']],
/* v */ ['null', ['v', 'v~']],
/* y */ ['symbol', ['y', 'z']],
/* z */ ['null', ['z', 'z~']],
/* z */ ['undefined', ['z', '{']],
/* | remotable->ordinal mapping prefix: This is not used in covers but it is
reserved from the same set of strings. Note that the prefix is > any
prefix used by any cover so that ordinal mapping keys are always outside
Expand Down