Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update sort order so undefined comes last #4252

Merged
merged 1 commit into from
Jan 8, 2022

Conversation

FUDCo
Copy link
Contributor

@FUDCo FUDCo commented Jan 7, 2022

This commit captures a minor tweak from the forthcoming collections & stores work that MarkM needs for an upcoming security review.

@FUDCo FUDCo added bug Something isn't working enhancement New feature or request automerge:rebase Automatically rebase updates, then merge stores labels Jan 7, 2022
@FUDCo FUDCo requested a review from erights January 7, 2022 21:11
@FUDCo FUDCo self-assigned this Jan 7, 2022
Copy link
Member

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge bug Something isn't working enhancement New feature or request stores
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants