fix(pserver): use with-blocks when possible #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warner
approved these changes
Jan 7, 2020
|
While you're in the neighborhood of cleanin up I started cleaning up |
|
I'd rather wait on that until we move the provisioning server to a cloud platform (which probably means it will be rewritten/redesigned in Node.js). That's when I intend to remove the magic wormhole dependency, too. "Remove ambient authority" is a little more far-reaching than "use with-blocks", which was purely mechanical. Although I'm sure the exercise would be enlightening, I can't just toss that one off in two minutes. |
dckc
pushed a commit
to dckc/agoric-sdk
that referenced
this pull request
Jan 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More use of
withblocks to keep file descriptor usage low.Part of the review of #382.