fix(xsnap)!: avoid O(n^2) Array, Map, Set growth #3560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warner
reviewed
Jul 30, 2021
dckc
force-pushed
the
3012-xs-perf
branch
2 times, most recently
from
080c0d8 to
b93a534
Compare
Moddable commit ff1bfaf04249 rendered mxMapEntriesIteratorPrototype obsolete in favor of mxMapIteratorPrototype and likewise several others. style: use standard return type for main() to avoid a warning that may distract from security review
XS implementation now has conventional O(n log(n)) algorithm. - xs-meter-9 represents XS Map/Set optimizations - style: update indentaion in test-xs-perf.js fixes #3012
|
For release management, the |
kriskowal
approved these changes
Jul 30, 2021
Comment on lines
-831
to
+833
| mxFreezeBuiltInCall; mxPush(mxMapKeysIteratorPrototype); mxFreezeBuiltInRun; | ||
| mxFreezeBuiltInCall; mxPush(mxMapValuesIteratorPrototype); mxFreezeBuiltInRun; | ||
| mxFreezeBuiltInCall; mxPush(mxMapIteratorPrototype); mxFreezeBuiltInRun; | ||
| mxFreezeBuiltInCall; mxPush(mxModulePrototype); mxFreezeBuiltInRun; | ||
| mxFreezeBuiltInCall; mxPush(mxRegExpStringIteratorPrototype); mxFreezeBuiltInRun; | ||
| mxFreezeBuiltInCall; mxPush(mxSetEntriesIteratorPrototype); mxFreezeBuiltInRun; | ||
| mxFreezeBuiltInCall; mxPush(mxSetKeysIteratorPrototype); mxFreezeBuiltInRun; | ||
| mxFreezeBuiltInCall; mxPush(mxSetValuesIteratorPrototype); mxFreezeBuiltInRun; | ||
| mxFreezeBuiltInCall; mxPush(mxSetIteratorPrototype); mxFreezeBuiltInRun; |
There was a problem hiding this comment.
Story checks out:
$ node
> new Map().keys().__proto__ === new Map().entries().__proto__
true
| @@ -138,7 +139,9 @@ test('metering can be switched off / on at run-time', async t => { | |||
| const opts = options(io); | |||
| const vat = xsnap(opts); | |||
| t.teardown(() => vat.terminate()); | |||
| const { meterUsage: { compute: noUnMeteredCompute } } = await vat.evaluate(` | |||
| const { | |||
| meterUsage: { compute: noUnMeteredCompute }, | |||
There was a problem hiding this comment.
nit: Maybe fullyMeteredCompute to cancel the negatives. I want to love giving Un its own camel hump, and also MoDem, TeleType, and TransCoder.
Comment on lines
+243
to
+244
| t.true(r2.rate / r1.rate >= 1); | ||
| t.true(r3.rate / r2.rate >= 1); |
There was a problem hiding this comment.
What do these assertions verify?
There was a problem hiding this comment.
that the data structure manipulation rate (computed above as n * logn / delta_t) stays comparable as the (binary) order of magnitude grows.
It used to be >= 0.85. Now that it's >= 1, it could just be r2.rate >= r1.rate, I suppose.
dckc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
BREAKING CHANGE: xs-meter-9 represents XS Map/Set optimizations
see also https://github.com/agoric-labs/moddable/tree/ag-testnet-5 ; this time, I merged Moddable's
publicbranch into our "vendor branch" rather than rebasing.commit 4372617 is work that we would have gotten for free if we had integrated Moddable's refactor of
xsnap.cinto platform and application. endojs/endo#681fixes #3012