Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate ibid tables #2596

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Separate ibid tables #2596

merged 1 commit into from
Mar 8, 2021

Conversation

erights
Copy link
Member

@erights erights commented Mar 8, 2021

Incremental maintenance on marshal.

(Happens to be steps towards a Justin renderer spike, but an improvement on its own.)

@erights erights requested a review from michaelfig March 8, 2021 08:37
@erights erights self-assigned this Mar 8, 2021
michaelfig
michaelfig approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like the refactoring.

@erights erights merged commit e0704eb into master Mar 8, 2021
@erights erights deleted the markm-justin branch March 8, 2021 17:56
@dckc
Copy link
Member

dckc commented Mar 8, 2021

I happened to take a look and I got confused by the fix: prefix. I was trying to figure out what bug was fixed... but now it's clear that there's no visible change; just a refactor. Shouldn't the prefix be refactor:? It matters more if packages/marshall/CHANGELOG.md is maintained using conventional commits. It's sort of hard to tell because there's also a NEWS.md file in marshall... that hasn't been updated since 2019.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelfig michaelfig michaelfig approved these changes

Assignees

@erights erights

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erights @dckc @michaelfig