refactor: remove all unnecessary @ts-ignore annotations

[michaelfig]

Either updates to the Typescript version we use in agoric-sdk, or cargo-culting means many of our @ts-ignore annotations are unnecessary.

I suggest that we should avoid @ts-ignore whenever we can: only use it when Typescript really has a bug we can't work around, such as #2438 (comment). Then, link to the corresponding open issue on the TypeScript repository in the same line as @ts-ignore.

[katelynsills]

The @ts-ignore annotations aren't cargo-culting. I put them there on purpose. In my local settings, I have type checking on by default (even without ts-check) and it is helpful to me to be able to type check the tests, and where the types are intentionally wrong in the tests (normally a t.throws test), to suppress that error. As it's not hurting anyone, and it's my preference, I would like to leave these as they are.

[katelynsills]

Please keep the @ts-ignore above t.throws and t.throwsAsync

[dckc]

I'd like to understand better why some of these are no longer necessary. Not critical.

I'm not sure about the Zoe stuff. I guess I'll stand by for Kate's comments... but that doesn't seem like an algorithm that terminates. Splitting the PR would make for a more clear process, but maybe that's more trouble than it's worth.

[dckc]

I don't understand why this is no longer necessary. hm.

[michaelfig]

The @ts-ignore annotations aren't cargo-culting. I put them there on purpose. In my local settings, I have type checking on by default (even without ts-check) and it is helpful to me to be able to type check the tests, and where the types are intentionally wrong in the tests (normally a t.throws test), to suppress that error. As it's not hurting anyone, and it's my preference, I would like to leave these as they are.

Sorry, I had assumed those files were running with @ts-check so when I removed the @ts-ignore I didn't see any effect.
I will revert those changes.

Would you like me to add @ts-check to them?

[katelynsills]

Sorry, I had assumed those files were running with @ts-check so when I removed the @ts-ignore I didn't see any effect.
I will revert those changes.

Would you like me to add @ts-check to them?

That would be great, thanks!

[michaelfig]

@katelynsills would you be able to take a look at the documentation snippets failure at: https://github.com/Agoric/agoric-sdk/pull/2441/checks?check_run_id=1913294837#step:12:10

Thanks!

[katelynsills]

@katelynsills would you be able to take a look at the documentation snippets failure at: https://github.com/Agoric/agoric-sdk/pull/2441/checks?check_run_id=1913294837#step:12:10

Thanks!

Yup!

[katelynsills]

LGTM! Thanks for doing this cleanup

[katelynsills]

Is this waiting on something? The documentation checks are passing 👍

[michaelfig]

Is this waiting on something? The documentation checks are passing 👍

Not waiting on anything now! Thanks for the prod.