Vat-side promise ID retirement #2358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warner
reviewed
Feb 8, 2021
| @@ -28,7 +28,7 @@ test('local vat manager', async t => { | |||
| t.deepEqual(JSON.parse(c.kpResolution(c.bootstrapResult).body), expected); | |||
| }); | |||
|
|
|||
| test('xs vat manager', async t => { | |||
| test.skip('xs vat manager', async t => { | |||
There was a problem hiding this comment.
that's fine, this test is going away in @dckc 's work anyways, to be replaced with the xsnap variant
There was a problem hiding this comment.
I don't know why I thought this was true. It's not. The xsnap variant uses the same test.
warner
reviewed
Feb 8, 2021
warner
reviewed
Feb 8, 2021
|
Looks pretty good. Please fix the minor |
FUDCo
commented
Feb 8, 2021
FUDCo
force-pushed
the
promise-gc-phase3-step3x
branch
from
ef8ec22 to
b433387
Compare
warner
approved these changes
Feb 8, 2021
FUDCo
force-pushed
the
promise-gc-phase3-step3x
branch
from
b433387 to
7b64a50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to allow vat-side promise ID retirement.
Note that the xs vat worker test (in
SwingSet/test/workers/test-worker.js) is currently disabled, as there's something in there that doesn't get along with these changes. This probably should be addressed before we land this.Also: doc changes still to come.