test(xsnap): Test xsnap close and terminate #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
force-pushed
the
xsnap-test-close-terminate
branch
from
a1c0d6a to
e174e49
Compare
dckc
approved these changes
Jan 21, 2021
|
shoot... #2225 doesn't seem to work when rebased on top of this. |
|
What’s the symptom of the failure?
…On Thu, Jan 21, 2021 at 11:52 AM Dan Connolly ***@***.***> wrote:
shoot... #2225 <#2225> doesn't
seem to work when rebased on top of this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2227 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAOXBUCHAEZ2YIQRYYJJZ3S3CAWTANCNFSM4WMGYZNQ>
.
|
|
A kernel level promise ends up pending rather than resolved. That's the high level symptoms. Haven't diagnosed it more finely. |
|
The semantics of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds tests to verify the behavior of graceful shutdown and graceless termination of an xsnap worker. Close signals to the xsnap worker that it will receive no further commands by closing the parentToChild file descriptor. Terminate sends a kill signal, and does not wait for the pending sequence of commands to flush (the “baton”).
Also added are some more debugging conveniences, like the threading of the Node.js writer stream and improved error messages. This also cleans up some of the debug vs non-debug switching.