improve test-worker.js to exercise all worker types, and syscall.callNow #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dckc look at |
dckc
approved these changes
Jan 20, 2021
Also hush some console messages, and test the local worker as well (for parallelism). closes #1778
This is the only type of worker which can currently handle syscall.callNow. The `node-subprocess` case theoretically could (the child subprocess could do a blocking read of the kernel-to-worker pipe while waiting for the result), but the code on either side of that pipe does not yet support that mode. The `nodeWorker` (Node.js threads) case cannot, because threads cannot block, at least not without heroics involving `Atomic` locks around a results-bearing `SharedArrayBuffer`. The old `xs-worker` case could not, for the same shallow implementation reasons as `node-subprocess`, but the new `xsnap` -based XS worker should be capable. closes #1617
dckc
force-pushed
the
1778-test-worker-notify
branch
from
2471c18 to
66aa3d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes and improves test-worker.js to:
syscall.callNowfor the workers that can handle it (onlylocalfor now, but the upcomingxsnap-based XS worker should be capable too)