-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Zoe Deposit in offer() by brand rather than keyword #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
changed the title
Zoe Deposit in offer() by brand rather than keyword
refactor: Zoe Deposit in offer() by brand rather than keyword
Jun 9, 2020
katelynsills
approved these changes
Jun 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Chris-Hibbert
force-pushed
the
issuerTableByBrand
branch
from
June 9, 2020 23:57
50af071
to
e4c4102
Compare
Chris-Hibbert
force-pushed
the
depositByBrand
branch
from
June 9, 2020 23:57
73f6173
to
4b9726f
Compare
Chris-Hibbert
force-pushed
the
issuerTableByBrand
branch
from
June 10, 2020 00:03
e4c4102
to
fddcb63
Compare
Extracted from Zoe facet parameters (in progress)
Extracted from Zoe facet parameters (in progress)
Extracted from Zoe facet parameters (in progress)
This was extracted from Zoe facet parameters, which is in progress
Chris-Hibbert
force-pushed
the
depositByBrand
branch
from
June 10, 2020 00:03
4b9726f
to
280ddea
Compare
Closed
warner
added a commit
that referenced
this pull request
Aug 20, 2020
I think this got added by accident in #1169
warner
added a commit
that referenced
this pull request
Aug 20, 2020
I think this got added by accident in #1169
This was referenced Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from Zoe facet parameters (#1129, #718, #1116, in progress)
closes #1021