Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Zoe Deposit in offer() by brand rather than keyword #1169

Merged
merged 4 commits into from
Jun 10, 2020

Conversation

Chris-Hibbert
Copy link
Contributor

Extracted from Zoe facet parameters (#1129, #718, #1116, in progress)

closes #1021

@Chris-Hibbert Chris-Hibbert changed the title Zoe Deposit in offer() by brand rather than keyword refactor: Zoe Deposit in offer() by brand rather than keyword Jun 9, 2020
@Chris-Hibbert Chris-Hibbert self-assigned this Jun 9, 2020
@Chris-Hibbert Chris-Hibbert added the Zoe package: Zoe label Jun 9, 2020
@Chris-Hibbert Chris-Hibbert changed the base branch from master to issuerTableByBrand June 9, 2020 21:47
Copy link
Contributor

@katelynsills katelynsills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Extracted from Zoe facet parameters (in progress)
Extracted from Zoe facet parameters (in progress)
Extracted from Zoe facet parameters (in progress)
This was extracted from Zoe facet parameters, which is in progress
Base automatically changed from issuerTableByBrand to master June 10, 2020 16:08
@Chris-Hibbert Chris-Hibbert merged commit 169d647 into master Jun 10, 2020
@Chris-Hibbert Chris-Hibbert deleted the depositByBrand branch June 10, 2020 16:09
warner added a commit that referenced this pull request Aug 20, 2020
I think this got added by accident in #1169
warner added a commit that referenced this pull request Aug 20, 2020
I think this got added by accident in #1169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Zoe package: Zoe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Zoe] Zoe should choose the purse to deposit into by brand, not by keyword
2 participants