Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Zoe] zoe.makeInstance returns an invite, not a record containing an 'invite' property #887

Closed
erights opened this issue Apr 8, 2020 · 2 comments · Fixed by #853
Closed

[Zoe] zoe.makeInstance returns an invite, not a record containing an 'invite' property #887

erights opened this issue Apr 8, 2020 · 2 comments · Fixed by #853
Assignees
@erights
Labels
Zoe package: Zoe
Milestone
Zoe 0.5.0

Comments

@erights
Copy link
Member

erights commented Apr 8, 2020

agoric-sdk/packages/zoe/test/swingsetTests/zoe/vat-alice.js

Line 300 in dda5944

const { invite } = await E(zoe).makeInstance(

This line uses destructuring to extract an 'invite' out of the return value of zoe.makeInstance. But it returns the invite itself, not a record.

Happens several places.
@erights erights self-assigned this Apr 8, 2020
@erights erights mentioned this issue Apr 8, 2020
Merged
@katelynsills katelynsills added the Zoe package: Zoe label Apr 8, 2020
@katelynsills katelynsills added this to the Zoe 0.5.0 milestone Apr 8, 2020
@DavidBruant
Copy link
Contributor

Related: #820

@Chris-Hibbert
Copy link
Contributor

fixed in #820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erights erights

Labels
Zoe package: Zoe
Projects
None yet
Milestone
Zoe 0.5.0
Development

Successfully merging a pull request may close this issue.

[Zoe] upcall refactoring of inviting to offer Agoric/agoric-sdk
4 participants
@DavidBruant @erights @katelynsills @Chris-Hibbert