Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line flag parity for agoric publish with agd tx swingset install-bundle #8554

Open
kriskowal opened this issue Nov 20, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@kriskowal
Copy link
Member

What is the Problem Being Solved?

We created agoric publish as a porcelain for submitting a bundle to the chain and watching for whether the SwingSet controller accepted or rejected the artifact. It originally shelled out to agd and we converted it to use CosmWasm instead. However, we do not have feature parity with agd when it comes to interacting with keychains, and it lacks other flags like --gas, so we’re still recommending agd.

Description of the Design

Revert to shelling out to agd and thread all of the agd CLI flags through. Keep the part that watches the chain for the acceptance of the bundle. Also verify ahead of time that the file contains JSON and has a valid ID since the chain can’t publish a usable update to agoric follow :bundles in vstorage unless it can parse and identify the bundle.

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

@kriskowal kriskowal added the enhancement New feature or request label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant