Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick xsnap fixes for next chain upgrade #8487

Open
2 tasks
mhofman opened this issue Nov 1, 2023 · 0 comments
Open
2 tasks

Cherry-pick xsnap fixes for next chain upgrade #8487

mhofman opened this issue Nov 1, 2023 · 0 comments
Assignees
Labels
blocked_by_XSupgrade items that require an XS upgrade before they can be solved. enhancement New feature or request xsnap the XS execution tool

Comments

@mhofman
Copy link
Member

mhofman commented Nov 1, 2023

What is the Problem Being Solved?

agoric-sdk is stuck on a fork of Moddable SDK 3.8.7 until we figure out our xsnap-worker upgrade story (see #6361).

In the meantime, some fixes landed in XS that do not affect behavior of programs that have executed on chain, and are thus safe to include in a software upgrade (technically they would be safe to be applied as a non consensus patch).

Description of the Design

Cherry pick fuzzing and similar fixes that have landed in the Moddable SDK.

Security Considerations

The goal is to remove the possibility that a permissioned contract would trigger buggy XS behavior in the future, simplifying audits.

Scaling Considerations

None

Test Plan

Moddable SDK up until 4.1 has been acceptance tested (see #6929) against pismo transcripts. Some fixes landed after that version. We should also run against current mainnet transcripts

Tasks

Upgrade Considerations

The fixes must not affect the observable execution of existing deployed programs. Since the upgrade will be done in consensus, it is allowed too affect the content of snapshots and the metering of execution, but that is not expected to be the case.

@mhofman mhofman added enhancement New feature or request xsnap the XS execution tool labels Nov 1, 2023
@mhofman mhofman self-assigned this Nov 1, 2023
@mhofman mhofman changed the title Cherry-pick xsnap fixes for upgrade-12 Cherry-pick xsnap fixes for upgrade-13 Nov 2, 2023
@mhofman mhofman changed the title Cherry-pick xsnap fixes for upgrade-13 Cherry-pick xsnap fixes for next chain upgrade Dec 11, 2023
@aj-agoric aj-agoric added the blocked_by_XSupgrade items that require an XS upgrade before they can be solved. label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked_by_XSupgrade items that require an XS upgrade before they can be solved. enhancement New feature or request xsnap the XS execution tool
Projects
None yet
Development

No branches or pull requests

2 participants