can't send to account by address: namesByAddress is empty

[dckc]

Tasks

Preview Give feedback

1. fix(provisioning): export useful namesByAddress #8821
   automerge:rebase +1
2. Core-eval not found after submit on new cosmos-sdk #8887
   agoric-cosmos bug +2
3. feat(cosmos): upgrade provisioning vat #8901
   automerge:squash +1

Describe the bug

#5822 involves sending assets to accounts by address. As described in #8115, it should work something like...

const destDepositFacet = E(home.namesByAddress).lookup(addr, 'depositFacet');

but E(namesByAddress).entries() is empty: it resolves to [].

@anilhelvaci reported seeing [] in a REPL. I reproduced it in an ava test.

To Reproduce

Steps to reproduce the behavior:

1. cd agoric-sdk/packages/vats
2. apply diff below to the sim/demo config provides home with .myAddressNameAdmin test to show the entries
3. yarn test test/bootstrapTests/test-demo-config.js -m '*home*'
4. see an empty list of entries: []

diff --git a/packages/vats/test/bootstrapTests/test-demo-config.js b/packages/vats/test/bootstrapTests/test-demo-config.js
index d9a53b5fd..41743b0c5 100644
--- a/packages/vats/test/bootstrapTests/test-demo-config.js
+++ b/packages/vats/test/bootstrapTests/test-demo-config.js
@@ -64,6 +64,8 @@ test('sim/demo config provides home with .myAddressNameAdmin', async t => {
   const home = await makeHomeFor(addr, EV);
   const actual = await EV(home.myAddressNameAdmin).getMyAddress();
   t.is(actual, addr, 'my address');
+  const xxx = await EV(home.namesByAddress).entries();
+  console.log('@@@@', xxx);
   keyArrayEqual(t, keys(home).sort(), homeKeys);
 });

Expected behavior

An entry for each provisioned user.

Platform Environment

• what OS are you using? what version of Node.js?

$ uname -a
Linux bldbox 5.15.0-76-generic #83-Ubuntu SMP Thu Jun 15 19:16:32 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
$ node --version
v18.14.0

• is there anything special/unusual about your platform?

I was working on a branch at the time I reproduced the problem, but it also reproduces on master.

• what version of the Agoric-SDK are you using? (run git describe --tags --always)
  @agoric/[email protected] e28392f

Additional context

@anilhelvaci reports that this is blocking a bounty issue that @schnetzlerjoe is working on (most likely #5822)

Screenshots

$ yarn test test/bootstrapTests/test-demo-config.js -m '*home*'
...
@@@@ []
  ✔ sim/demo config provides home with .myAddressNameAdmin (16.2s)
    ℹ bootstrap produced provisioning vat

[dckc]

workaround for vat-provisioning on local chains

@schnetzlerjoe does 71a2c83 get your bounty issue work un-stuck?

For ref: I started a branch: 8113-provision-names. currently:

• 71a2c83 fix(provisioning): don't use disconnected namesByAddress
• 2796df2 chore(provisioning): extra NameHub tracing

cc @michaelfig @anilhelvaci

p.s. @schnetzlerjoe says:

This works like a charm!!!!!

[dckc]

TODO: find consumers of disconnected namesByAddress

Somehow this didn't impact sending invitations to EC members and oracle operators. I suppose those functions used namesByAddressAdmin.

But anything that consumed namesByAddress has got a useless unrelated NameHub.

cc @turadg

p.s. done: #8786 (comment)

[dckc]

impact: cannot send assets to account by address

I'm inclined to change the title to be more about this.

Background:

• how to send an ERTP payment to an agoric / cosmos address / account #8115

[dckc]

work-around idea

In a core-eval proposal, rather than using { consume: { agoricNames } }, use { consume: { agoricNamesAdmin } } and then const agoricNames = E(agoricNamesAdmin).readOnly().

[dckc]

The work-around triggered another bug: #8408

There we have a more complete work-around.

[0xpatrickdev]

use { consume: { agoricNamesAdmin } } and then const agoricNames = E(agoricNamesAdmin).readOnly().

Is it possible to create a power called agoricNamesAdminReadOnly, or agoricNamesReadOnly ?

Relatedly, I wonder if we can do something like this to better scope permit permissions for writing to agoricNames:

{
  "consume": {
    "chainStorage": {
      "agoricNamesAdmin": {
        "instance": {
          "MyContract": true,
          "MySecondContract": true
        }
      }
    }
  }
}

[dckc]

agoricNamesAdminReadOnly is called agoricNames.

And for installation, instance, brand, and issuer, the stuff is already shaped like this:

{
  consume: {...},
  instance: {
    produce: {
      MyContract: true,
      MySecondContract: true,
    }
  }
}

And the contents of these namehubs are automatically reflected to chainStorage.

p.s. see makeWellKnownSpaces