Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for Auctioneer upgrade retaining bids #7955

Open
Tracked by #7159 ...
turadg opened this issue Jun 19, 2023 · 2 comments
Open
Tracked by #7159 ...

test for Auctioneer upgrade retaining bids #7955

turadg opened this issue Jun 19, 2023 · 2 comments

Comments

@turadg
Copy link
Member

turadg commented Jun 19, 2023

What is the Problem Being Solved?

Our “upgrade” of Auctioneer will be making a new one and giving it to Vault Factory for liquidations. Any outstanding bids in old one will remain but won’t ever be satisfied.

Bidders will be able to pull their bids from that one and, if desired, make them anew on the new one.

Description of the Design

Work item here is to verify that a bidder can cancel their bid on the old auction after the new auction is in production.

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

The new Auctioneer shouldn't clobber the execution of the old one.

@Chris-Hibbert
Copy link
Contributor

@turadg would you say more about what you want to see here? I thought the plan of record was to pick a time when the vaultFactory doesn't have any collateral up for sale in the auction, and upgrade the vaultFactory to a newly installed auction, leaving the old auction in place. If there are any outstanding bids on the old auction, their owners can withdraw them when convenient.

There was also some discussion of finding ways to upgrade the old auction to one that could be exited, but I thought that was more about deleting the old vat than ensuring that bidders withdraw their bids.

@turadg
Copy link
Member Author

turadg commented Jul 27, 2023

I've filled out the Work Item template. (Issue was made via Tasklists which makes them empty)

There was also some discussion of finding ways to upgrade the old auction to one that could be exited, but I thought that was more about deleting the old vat than ensuring that bidders withdraw their bids.

Thanks for highlighting. That's something that requires more design. I've added it as a task to the parent issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants