Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support swingstore rollback #7951

Closed
mhofman opened this issue Jun 19, 2023 · 1 comment
Closed

Support swingstore rollback #7951

mhofman opened this issue Jun 19, 2023 · 1 comment

Comments

@mhofman
Copy link
Member

mhofman commented Jun 19, 2023

What is the Problem Being Solved?

If a node encounters a divergence, resulting in a consensus failure, there is currently no way to rollback the JS state that may have caused the divergence.

agd supports a rollback command, but that only affects the cosmos state. If the cosmos state is rolled back by one block, the handover inconsistency logic will just kick in, and cosmic-swingset will simply replay the chain sends of the last block.

Description of the Design

Maybe something based on an SQLite undo log.

An alternative would be to abuse the WAL system.

Security Considerations

None

Scaling Considerations

How many blocks should the rollback window be?

Impact on #6447 ?

Test Plan

TBD

@mhofman
Copy link
Member Author

mhofman commented Jul 10, 2023

Closing in favor of #7963

@mhofman mhofman closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant