Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartWallet tryExitOffer requires spend authority #7291

Open
dckc opened this issue Mar 31, 2023 · 1 comment
Open

smartWallet tryExitOffer requires spend authority #7291

dckc opened this issue Mar 31, 2023 · 1 comment
Labels
bug Something isn't working vaults_triage DO NOT USE wallet

Comments

@dckc
Copy link
Member

dckc commented Mar 31, 2023

Describe the bug

As part of #6930 , I'm trying to cancel a bid with agd tx swingset wallet-action XXX. Since that doesn't require withdrawing from any purses, I thought I wouldn't need the --allow-spend flag. But I get Error: tryExitOffer requires spend authority.

To Reproduce

Send the bridge action in the log below

Expected behavior

tryExit should not need the spend flag.

Platform Environment

ollinet
Revision Link: https://github.com/Agoric/agoric-sdk/tree/7989b8857a728c7b7b937077757520f0cadeebde

Additional context

part of #6930

Screenshots

2023-03-31T01:47:15.634Z SwingSet: vat: v25: walletFactory.fromBridge: { action: '{"body":"{\\"method\\":\\"tryExitOffer\\",\\"offerId\\":\\"bid-1680220217218\\"}","slots":[]}', blockHeight: 52242, blockTime: 1680227229, owner: 'agoric140dmkrz2e42ergjj7gyvejhzmjzurvqeq82ang', type: 'WALLET_ACTION' }
2023-03-31T01:47:15.637Z SwingSet: vat: v25: walletFactory: { wallet: Object [Alleged: SmartWallet self] {}, actionCapData: { body: '{"method":"tryExitOffer","offerId":"bid-1680220217218"}', slots: [] } }
2023-03-31T01:47:15.669Z SwingSet: ls: v25: Logging sent error stack (Error#98)
2023-03-31T01:47:15.670Z SwingSet: ls: v25: Error#98: tryExitOffer requires spend authority

cc @turadg

@dckc dckc added bug Something isn't working wallet labels Mar 31, 2023
@dckc
Copy link
Member Author

dckc commented Mar 31, 2023

@samsiegart points out: there's a question of whether removing the spend flag means: this action is suitable for use with a background signer (#4406).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vaults_triage DO NOT USE wallet
Projects
None yet
Development

No branches or pull requests

2 participants