Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore or replace test-gov-collateral #7175

Closed
turadg opened this issue Mar 16, 2023 · 3 comments · Fixed by #8149
Closed

restore or replace test-gov-collateral #7175

turadg opened this issue Mar 16, 2023 · 3 comments · Fixed by #8149
Assignees
Labels
enhancement New feature or request vaults_triage DO NOT USE

Comments

@turadg
Copy link
Member

turadg commented Mar 16, 2023

What is the Problem Being Solved?

This test for the ability of the BLDer DAO to add vault collateral types is brittle to maintain and was disabled in #7047

Description of the Design

Improve its setup to be less bespoke or move what it tests into other tests

Security Considerations

Scaling Considerations

Test Plan

@turadg turadg added the enhancement New feature or request label Mar 16, 2023
@otoole-brendan otoole-brendan added this to the Vaults EVP milestone Mar 20, 2023
@otoole-brendan otoole-brendan added the vaults_triage DO NOT USE label Mar 20, 2023
@ivanlei ivanlei removed this from the Vaults EVP milestone Apr 19, 2023
@dckc
Copy link
Member

dckc commented Aug 3, 2023

I think it's subsumed by...

test.serial('add STARS collateral', async t => {
const { controller, buildProposal } = t.context;
t.log('building proposal');
const proposal = await buildProposal({
package: 'inter-protocol',
packageScriptName: 'build:add-STARS-proposal',
});

@Chris-Hibbert
Copy link
Contributor

At a glance, it appears that test-liquidation-1 includes tests that match 'Benefactor can add to reserve' and 'assets are in Vaults', It doesn't appear that it covers 'voters get invitations' or 'Committee can raise debt limit'.

Are the latter two worth resurrecting? Do we have better places to test that functionality?

@dckc
Copy link
Member

dckc commented Aug 4, 2023

I think invitations and debt limit are sufficiently tested elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vaults_triage DO NOT USE
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants