Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky "dispatches to the dead do not harm kernel" CI test failing on anachrophobia #7078

Closed
mhofman opened this issue Feb 25, 2023 · 4 comments
Assignees
Labels
duplicate liveslots requires vat-upgrade to deploy changes SwingSet package: SwingSet vaults_triage DO NOT USE
Milestone

Comments

@mhofman
Copy link
Member

mhofman commented Feb 25, 2023

We've gotten hit by a flaky test in CI failing on an anachrophobia.

Relevant details from the failing test:

anachrophobia strikes vat v2 on delivery 7
delivery completed with 4 expected syscalls remaining
expected: {"0":"vatstoreGet","1":"vom.rc.o-50","length":2}
expected: {"0":"vatstoreGetNextKey","1":"vom.ir.o-50|","length":2}
expected: {"0":"dropImports","1":{"0":"o-50","length":1},"length":2}
expected: {"0":"retireImports","1":{"0":"o-50","length":1},"length":2}
REJECTED from ava test: (Error#124)
Error#124: historical inaccuracy in replay of v2
  at Object.finishReplayDelivery (.../swingset-vat/src/kernel/vat-loader/transcript.js:81:13)
  at replayOneDelivery (.../swingset-vat/src/kernel/vat-loader/manager-helper.js:191:19)
  at async Object.replayTranscript (.../swingset-vat/src/kernel/vat-loader/manager-helper.js:218:1)
  at async ensureVatOnline (.../swingset-vat/src/kernel/vat-warehouse.js:133:1)
  at async Object.start (.../swingset-vat/src/kernel/vat-warehouse.js:181:1)
  at async Object.start (.../swingset-vat/src/kernel/kernel.js:1565:1)
  at async makeSwingsetController (packages/SwingSet/src/controller/controller.js:309:3)
  at async buildVatController (packages/SwingSet/src/controller/controller.js:543:22)
  at async packages/SwingSet/test/vat-admin/terminate/test-terminate.js:414:16

not ok 182 - vat-admin › terminate › terminate › dispatches to the dead do not harm kernel %ava-dur=6911ms

I could not reproduce locally, but it happened at least twice in CI:

May be related to #6784

@mhofman mhofman changed the title Flaky "dispatches to the dead do not harm kernel" test failing on anachrophobia failure CI failing on an anachrophobia Flaky "dispatches to the dead do not harm kernel" CI test failing on anachrophobia failure Feb 25, 2023
@mhofman mhofman changed the title Flaky "dispatches to the dead do not harm kernel" CI test failing on anachrophobia failure Flaky "dispatches to the dead do not harm kernel" CI test failing on anachrophobia Feb 25, 2023
@mhofman mhofman added SwingSet package: SwingSet liveslots requires vat-upgrade to deploy changes labels Feb 25, 2023
@ivanlei ivanlei added this to the Vaults EVP milestone Feb 27, 2023
@warner
Copy link
Member

warner commented Feb 27, 2023

Is this running under the local (Node.js) worker? We've had rotten luck getting GC to work consistently under Node, and this might be another expression of that. #5202 / #4936

@warner
Copy link
Member

warner commented Feb 27, 2023

I'm starting to think that all but the simplest of GC tests should be configured to run only under XS.

@ivanlei ivanlei added the vaults_triage DO NOT USE label Feb 27, 2023
@mhofman
Copy link
Member Author

mhofman commented Feb 27, 2023

I guess it was both times under Node. We should probably separate more clearly the tests that don't use xsnap-worker. I can't really see a good reason to run tests that use liveslots under node.

@ivanlei
Copy link
Contributor

ivanlei commented Mar 2, 2023

This is a dupe of #6692

@ivanlei ivanlei closed this as completed Mar 2, 2023
@dckc dckc added the duplicate label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate liveslots requires vat-upgrade to deploy changes SwingSet package: SwingSet vaults_triage DO NOT USE
Projects
None yet
Development

No branches or pull requests

4 participants