Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auction targets a specific amount of IST to raise; returns excess collateral to vault holders #6952

Closed
rowgraus opened this issue Feb 8, 2023 · 2 comments · Fixed by #7239
Assignees
Labels
enhancement New feature or request vaults_triage DO NOT USE

Comments

@rowgraus
Copy link

rowgraus commented Feb 8, 2023

What is the Problem Being Solved?

Due to overcollateralization of vaults, significantly more collateral may be sent to liquidation than is actually needed to cover debt.

Vault holders would prefer to receive excess collateral back rather than having it sold.

Description of the Design

Security Considerations

Scaling Considerations

Test Plan

@rowgraus rowgraus added the enhancement New feature or request label Feb 8, 2023
@rowgraus rowgraus added this to the Vaults Functional Testing milestone Feb 8, 2023
@ivanlei ivanlei added the vaults_triage DO NOT USE label Feb 13, 2023
@Chris-Hibbert
Copy link
Contributor

@rowgraus
If there are more than one contributor to an auction, do you have a preference for how their limits get combined? I see two main plausible cases: a) two Vaults with different parameter settings for the same asset, and b) a vault and the reserve, which would likely not want to set a maximum sale.

There are three obvious choices, two of them easy, and the third requiring more work. (for design/test/implement the runtime wouldn't likely matter.)

  1. take the minimum proportion of the two (or more) requests. The other vaultManager would get less IST than required to cover the debt
  2. take the maximum proportion of the two (or more) requests. The other vaultManager would get IST returned above the debt, and would return it to vaultHolders. (that distribution code is already written.)
  3. track the requirements from the two (or more) requests through the auction, so the auctioneer can pro-rate the returns across different asset classes.

If 1) or 2) is acceptable (only) for the near-term, we can put off implementing 3) until we add support for multiple vaultManagers for an asset, or enable the Reserve to sell to the auction. Alternatively, we could make the auctioneer refuse to accept more than one deposit for an asset during one cycle, so the Reserve would be limited to selling during rising markets. This wouldn't support multiple vaultManagers liquidating the same asset, but we may not be getting to that soon.

@Chris-Hibbert
Copy link
Contributor

@rowgraus and I chatted, and he chose 3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vaults_triage DO NOT USE
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants