Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After-commit block action #6563

Closed
mhofman opened this issue Nov 14, 2022 · 1 comment · Fixed by #7225
Closed

After-commit block action #6563

mhofman opened this issue Nov 14, 2022 · 1 comment · Fixed by #7225
Assignees
Labels
cosmic-swingset package: cosmic-swingset enhancement New feature or request vaults_triage DO NOT USE
Milestone

Comments

@mhofman
Copy link
Member

mhofman commented Nov 14, 2022

What is the Problem Being Solved?

In order to measure the impact of #5934, we need to understand the impact of commiting more data to the IAVL tree. Currently all our telemetry flows through the JS side, using slog events generated by cosmic-swingset and swingset.

In order to get insight into the go side of things, we need to generate an event after go has fully committed its state.

Description of the Design

After commiting, go could send a non-blocking AFTER_COMMIT action. It may be acceptable for this action to re-use the existing BLockingSend mechanism if the JS side doesn't perform overly expensive work during that action.

Consensus considerations

The basic plumbing may actually be a change that has no change on consensus, and may provide valuable telemetry insight outside of state-sync.

Test Plan

TBD

@mhofman
Copy link
Member Author

mhofman commented Feb 12, 2023

Taking this on as part of state-sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmic-swingset package: cosmic-swingset enhancement New feature or request vaults_triage DO NOT USE
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants