You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The new smart wallet doesn't yet support adding issuers, so it can't hold the brands of the AMM liquidity tokens.
We took out suggestIssuer for PSM launch to reduce upgrade risk. The plan for #6099 is to blow away and recreate the wallet contract. That requires that all assets are held at the Cosmos level so they can be re-associated with the JS purses. (Except for Invitations which are not held in Cosmos; they will be lost and have to be provided again.)
AMM liquidity tokens are not in Cosmos banks and thus would get blown away until we can retain non-Cosmos assets through upgrade.
The liquidity issuer could get into the wallet by a user calling suggestIssuer. Alternately the walletFactory could be aware of the canonical AMM and add its issuers automatically. The latter has the advantage of having trusted names, should we not support petnames at MN-1 launch.
Acceptance criteria
wallet contract has AMM issuers and test-amm-integration does trades
wallet UI has the liquidity tokens
dapp-amm can use the above to trade in a browser
Security Considerations
Test Plan
The text was updated successfully, but these errors were encountered:
What is the Problem Being Solved?
The new smart wallet doesn't yet support adding issuers, so it can't hold the brands of the AMM liquidity tokens.
We took out
suggestIssuer
for PSM launch to reduce upgrade risk. The plan for #6099 is to blow away and recreate the wallet contract. That requires that all assets are held at the Cosmos level so they can be re-associated with the JS purses. (Except for Invitations which are not held in Cosmos; they will be lost and have to be provided again.)AMM liquidity tokens are not in Cosmos banks and thus would get blown away until we can retain non-Cosmos assets through upgrade.
Description of the Design
Depends on new upgrade capability:
The liquidity issuer could get into the wallet by a user calling
suggestIssuer
. Alternately the walletFactory could be aware of the canonical AMM and add its issuers automatically. The latter has the advantage of having trusted names, should we not support petnames at MN-1 launch.Acceptance criteria
Security Considerations
Test Plan
The text was updated successfully, but these errors were encountered: