Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[story] Support AMM trading in new smart wallet #6132

Open
turadg opened this issue Sep 4, 2022 · 1 comment
Open

[story] Support AMM trading in new smart wallet #6132

turadg opened this issue Sep 4, 2022 · 1 comment
Labels
AMM enhancement New feature or request vaults_triage DO NOT USE wallet

Comments

@turadg
Copy link
Member

turadg commented Sep 4, 2022

What is the Problem Being Solved?

The new smart wallet doesn't yet support adding issuers, so it can't hold the brands of the AMM liquidity tokens.

We took out suggestIssuer for PSM launch to reduce upgrade risk. The plan for #6099 is to blow away and recreate the wallet contract. That requires that all assets are held at the Cosmos level so they can be re-associated with the JS purses. (Except for Invitations which are not held in Cosmos; they will be lost and have to be provided again.)

AMM liquidity tokens are not in Cosmos banks and thus would get blown away until we can retain non-Cosmos assets through upgrade.

Description of the Design

Depends on new upgrade capability:

The liquidity issuer could get into the wallet by a user calling suggestIssuer. Alternately the walletFactory could be aware of the canonical AMM and add its issuers automatically. The latter has the advantage of having trusted names, should we not support petnames at MN-1 launch.

Acceptance criteria

  • wallet contract has AMM issuers and test-amm-integration does trades
  • wallet UI has the liquidity tokens
  • dapp-amm can use the above to trade in a browser

Security Considerations

Test Plan

@turadg turadg added enhancement New feature or request wallet labels Sep 4, 2022
@Tartuffo Tartuffo added this to the Mainnet 1 RC0 milestone Sep 4, 2022
@dckc
Copy link
Member

dckc commented Sep 5, 2022

The plan for #6099 is to blow away and recreate the wallet contract.

I wonder about that. My understanding of #6099 is that plan A is to use the Zoe contract upgrade stuff for the PSM contract alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AMM enhancement New feature or request vaults_triage DO NOT USE wallet
Projects
None yet
Development

No branches or pull requests

4 participants