Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ERTP] Check when union of MathHelpers.doAdd(left, right) is not disjoint #563

Closed
katelynsills opened this issue Feb 17, 2020 · 1 comment
Closed

[ERTP] Check when union of MathHelpers.doAdd(left, right) is not disjoint #563

katelynsills opened this issue Feb 17, 2020 · 1 comment
Labels
ERTP package: ERTP

Comments

@katelynsills
Copy link
Contributor

@erights says of natListMathHelpers.doAdd:

In light of #557 we should at least instrument this to see when the union is not disjoint, and try to understand why that happens. Once we understand this better, we might want to make this throw if left and right intersect. Doesn't need to happen in this PR, but if not, please file an issue or extend #557
@katelynsills katelynsills added the ERTP package: ERTP label Feb 17, 2020
@katelynsills
Copy link
Contributor Author

In #523, we already successfully throw if left and right intersect in all MathHelpers. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ERTP package: ERTP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@katelynsills