Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeVatConsole lacks methods of the SES VirtualConsole type #5453

Open
turadg opened this issue May 27, 2022 · 2 comments
Open

makeVatConsole lacks methods of the SES VirtualConsole type #5453

turadg opened this issue May 27, 2022 · 2 comments
Labels
bug Something isn't working SwingSet package: SwingSet tooling repo-wide infrastructure

Comments

@turadg
Copy link
Member

turadg commented May 27, 2022

What is the Problem Being Solved?

Some console method while coding in SDK are not available in swingset vats. The error (e.g. for console.trace) is cryptic because it doesn't mention console.trace or even console, just the outer method.

Tests of these that run in Node will work, but then fail in XS tests which are harder to debug.

Acceptance criteria

the console type while coding in agoric-sdk matches the available console object during code execution

Description of the Design

That could be by making Swingset's console support the console API or by modifying the typedef for the global console. I'd prefer to support the API as much as possible (if even with throwing "not implemented") than to create more special cases.

Security Considerations

The current approach puts console management in SDK when it would be safer to have lower in the environment.

Test Plan

TBD

@turadg turadg added enhancement New feature or request tooling repo-wide infrastructure xsnap the XS execution tool labels May 27, 2022
@dckc dckc added SwingSet package: SwingSet and removed xsnap the XS execution tool labels May 27, 2022
@dckc
Copy link
Member

dckc commented May 27, 2022

another way to phrase this would be as a bug:

  • makeVatConsole lacks trace() etc.; should match SES VirtualConsole type.

@turadg
Copy link
Member Author

turadg commented May 27, 2022

Fair enough. I was thinking it wouldn't merit a patch version bump but maybe so. I'll change the label.

@turadg turadg added bug Something isn't working and removed enhancement New feature or request labels May 27, 2022
@turadg turadg changed the title make console object runtime match static types makeVatConsole lacks methods of the SES VirtualConsole type May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SwingSet package: SwingSet tooling repo-wide infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants