Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slog-to-otel outdated by change from method+args to methargs #5445

Closed
dckc opened this issue May 26, 2022 · 3 comments · Fixed by #5455
Closed

slog-to-otel outdated by change from method+args to methargs #5445

dckc opened this issue May 26, 2022 · 3 comments · Fixed by #5455
Labels
bug Something isn't working cosmic-swingset package: cosmic-swingset

Comments

@dckc
Copy link
Member

dckc commented May 26, 2022

Description

Starting xnet (#5375) failed in slog-to-otel.js.

To Reproduce

try to start a node with telemetry (SLOGSENDER=@agoric/telemetry/src/otel-trace.js).

Platform Environment

instagoric a98368e

Symptoms

022-05-26T20:05:44.876Z block-manager: block bootstrap
Unknown crank-start message.type startVat
Unknown crank-start message.type startVat
Unknown crank-start message.type startVat
Unknown crank-start message.type startVat
Unknown crank-start message.type startVat
Error tracing slog: {
  time: 1653595544.8906558,
  type: 'crank-start',
  message: {
    type: 'send',
    target: 'ko21',
    msg: { methargs: [Object], result: 'kp40' }
  }
} (TypeError#1)
TypeError#1: Cannot read property 'slots' of undefined

  at extractMessageAttrs (packages/telemetry/src/slog-to-otel.js:107:60)
  at slogSender (packages/telemetry/src/slog-to-otel.js:596:43)
  at wrappedSlogSender (packages/telemetry/src/slog-to-otel.js:633:7)
  at writeSlogObject (packages/SwingSet/src/controller/controller.js:222:7)
  at Object.write (.../swingset-vat/src/kernel/slogger.js:111:27)
  at processAcceptanceMessage (.../swingset-vat/src/kernel/kernel.js:1103:12)
  at tryProcessMessage (.../swingset-vat/src/kernel/kernel.js:1095:8)
  at Object.run (.../swingset-vat/src/kernel/kernel.js:1518:25)
  at async crankScheduler (packages/cosmic-swingset/src/kernel-stats.js:315:5)
  at async bootstrapBlock (packages/cosmic-swingset/src/launch-chain.js:235:5)
  at async blockingSend (packages/cosmic-swingset/src/block-manager.js:144:9)
  at async portHandlers.<computed> (packages/cosmic-swingset/src/chain-main.js:215:16)

portHandler threw (TypeError#1)

reporting on behalf of @michaelfig
cc @arirubinstein @warner @FUDCo @Tartuffo

@dckc dckc added bug Something isn't working cosmic-swingset package: cosmic-swingset labels May 26, 2022
@mhofman
Copy link
Member

mhofman commented May 27, 2022

As mentioned offline, we should enable the otel telemetry in the deployment integration test.

@michaelfig

This comment was marked as resolved.

@michaelfig michaelfig reopened this May 30, 2022
@michaelfig

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cosmic-swingset package: cosmic-swingset
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants