Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitrot in fake virtual object support #4591

Closed
FUDCo opened this issue Feb 17, 2022 · 0 comments · Fixed by #4592
Closed

Bitrot in fake virtual object support #4591

FUDCo opened this issue Feb 17, 2022 · 0 comments · Fixed by #4592
Assignees
@FUDCo
Labels
bug Something isn't working stores SwingSet package: SwingSet test
Milestone
Mainnet 1 RC0

Comments

@FUDCo
Copy link
Contributor

FUDCo commented Feb 17, 2022

Describe the bug

Somehow, SwingSet's test mock virtual object support makes reference to the VOM method makeVirtualObjectRepresentative which no longer exists, having been superseded by the VRM method reanimate. Some of @turadg's test code was breaking as a result.
@FUDCo FUDCo added bug Something isn't working SwingSet package: SwingSet test stores labels Feb 17, 2022
@FUDCo FUDCo self-assigned this Feb 17, 2022
FUDCo added a commit that referenced this issue Feb 17, 2022
@FUDCo
fix: fake VOM bitrot
c9faf9c 
Closes #4591
@FUDCo FUDCo mentioned this issue Feb 17, 2022
Merged
@mergify mergify bot closed this as completed in #4592 Feb 17, 2022
@Tartuffo Tartuffo added this to the Mainnet 1 milestone Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FUDCo FUDCo

Labels
bug Something isn't working stores SwingSet package: SwingSet test
Projects
None yet
Milestone
Mainnet 1 RC0
Development

Successfully merging a pull request may close this issue.

Fix bitrot in mock VOM implementation Agoric/agoric-sdk
2 participants
@Tartuffo @FUDCo