Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement or Integrate SIGN_MODE_TEXTUAL #4529

Open
JimLarson opened this issue Feb 11, 2022 · 4 comments
Open

Implement or Integrate SIGN_MODE_TEXTUAL #4529

JimLarson opened this issue Feb 11, 2022 · 4 comments
Assignees
@JeancarloBarrios
Labels
agoric-cosmos Epic vaults_triage DO NOT USE

Comments

@JimLarson
Copy link
Contributor

See the cosmos-sdk activity:
@JimLarson JimLarson self-assigned this Feb 11, 2022
@JimLarson JimLarson added the Epic label Feb 11, 2022
@JimLarson
Copy link
Contributor Author

Last Architecture Review discussion on 2021-05-07

@JimLarson
Copy link
Contributor Author

Cosmos community has an updated spec (ADR-050) out for review: cosmos/cosmos-sdk#10701

@Tartuffo Tartuffo added this to the Mainnet 1 milestone Mar 23, 2022
@Tartuffo
Copy link
Contributor

Cosmos draft ADR here: https://github.com/cosmos/cosmos-sdk/blob/master/docs/architecture/adr-036-arbitrary-signature.md

@dckc
Copy link
Member

dckc commented May 11, 2022

I suggest re-phrasing the title and description to something like "sign offer with ledger using sign-mode-textual" or even "sign AMM offer" to be more specific. Let's start with the user problem and let it lead us to the solution.

And tell a story of the parties to the transaction. maybe include a quick mermaid interaction diagram.

@dckc dckc mentioned this issue May 18, 2022
Closed
@Tartuffo Tartuffo removed this from the Mainnet 1 RC0 milestone Sep 21, 2022
@dckc dckc mentioned this issue Dec 7, 2022
Closed
@rowgraus rowgraus added vaults_triage DO NOT USE and removed MUST-HAVE labels Dec 20, 2022
@ivanlei ivanlei assigned ivanlei and unassigned JimLarson Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeancarloBarrios JeancarloBarrios

Labels
agoric-cosmos Epic vaults_triage DO NOT USE
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@dckc @Tartuffo @ivanlei @JeancarloBarrios @JimLarson @rowgraus