Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert timer device to "raw device", remove userspace wiring requirement #4492

Open
warner opened this issue Feb 7, 2022 · 1 comment
Open
Labels
SwingSet package: SwingSet

Comments

@warner
Copy link
Member

warner commented Feb 7, 2022

As mentioned in #1346, when we next do significant work on the Timer device (perhaps because of #4282 or #4286), we should consider converting it to a "raw device", enhancing deviceTools.js to make it easier to manipulate Promises, and merge the companion vat (src/devices/timer.js and src/devices/timer-src.js). This would remove the unfortunate requirement that userspace bootstrap() glue the timer device to the timer vat.

One open question is whether userspace should then use vats.timer or devices.timer. The former is probably cleaner, but would probably require a lot of userspace code to be modified.

We'd want userspace to continue to be able to make E() calls to use the timer, which means enhancing raw devices to handle object references well. That might be a larger task than simply exposing device nodes that could work with promises.

@warner warner added the SwingSet package: SwingSet label Feb 7, 2022
@warner
Copy link
Member Author

warner commented Feb 9, 2022

It'd be nice to do this, but it doesn't help userspace much, so I can't justify including it in MN-1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SwingSet package: SwingSet
Projects
None yet
Development

No branches or pull requests

2 participants