Fix fullOrder leak. Semi-fungibles via CopyBags #4305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-stateful-merge-only
branch
3 times, most recently
from
4342b0b to
6c1a981
Compare
erights
changed the title
erights
force-pushed
the
markm-stateful-merge-only
branch
10 times, most recently
from
ff747c3 to
32cd07f
Compare
erights
force-pushed
the
markm-stateful-merge-only
branch
from
32cd07f to
55a4bd8
Compare
gibson042
approved these changes
Jan 28, 2022
erights
changed the title
erights
force-pushed
the
markm-stateful-merge-only
branch
from
ce019dc to
fb89bab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4261
Fixes that many copySet functions, and functions over keys of a copySet, were not checking that their elements were indeed keys, rather than other kinds of passables. To do this well involved both renamings for clarity (elements vs keys) and moving the exported functions to where they could close the loop and certify sets as correct, including that they contain only keys.