Extract early changes from PR 4136 #4190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 19, 2021
Merged
erights
force-pushed
the
markm-4136-extract-early
branch
from
0f9df16 to
733b2cd
Compare
|
Modulo the rank upper bound inclusive vs. exclusive thing we discussed yesterday, this all looks reasonable. |
erights
force-pushed
the
markm-4136-extract-early
branch
from
75f88e3 to
0f0b1ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the marshal and store level changes from #4136 seem ready to merge into master, and would help with other things I want to do. In particular, it gives us the basic pattern language, as well as the basic in-memory ephemeral stores. The kernel mods from #4136 are omitted, and therefore also the new support for virtual or durable stores.
Also omitted are the draft documentation pages even for marshal and store levels, as these have not yet been updated to explain the current semantics accurately.
All omitted elements from #4136 are expected to arrive in later PRs, unless stated otherwise.