Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault periods should be static #4185

Closed
Chris-Hibbert opened this issue Dec 16, 2021 · 2 comments · Fixed by #4394
Closed

Vault periods should be static #4185

Chris-Hibbert opened this issue Dec 16, 2021 · 2 comments · Fixed by #4394
Assignees
Labels
Core Economy OBSOLETE in favor of INTER-protocol enhancement New feature or request good first issue Good for newcomers Inter-protocol Overarching Inter Protocol restival to be done before RUN Protocol Purple Team festival
Milestone

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

The periods for charging interest and for recording updates are currently governed separately for each collateral type. The values should be consistent across collateral, and could likely be set at chain start-up and not be allowed to change.

Security Considerations

This moves some governed parameters around. If the periods are static, then they won't be visible through governance.

Test Plan

drops some mutability, so tests should mostly get simplified.

@Chris-Hibbert Chris-Hibbert added enhancement New feature or request Core Economy OBSOLETE in favor of INTER-protocol Inter-protocol Overarching Inter Protocol labels Dec 16, 2021
@Chris-Hibbert Chris-Hibbert added this to the Mainnet: Phase 1 - Treasury Launch milestone Dec 16, 2021
@Chris-Hibbert Chris-Hibbert self-assigned this Dec 16, 2021
@Chris-Hibbert Chris-Hibbert added the good first issue Good for newcomers label Jan 18, 2022
@rowgraus rowgraus added the MN-1 label Jan 19, 2022
@Tartuffo Tartuffo added the restival to be done before RUN Protocol Purple Team festival label Jan 24, 2022
@turadg
Copy link
Member

turadg commented Jan 26, 2022

Discussion in RUN meeting:

  • it's important to have a way to tweak the periods if needed
  • therefore it should be governed, but shared across all brands

@dckc has some ideas for how to implement

@dckc
Copy link
Member

dckc commented Jan 26, 2022

governed parameter across all assets / brands

In some sense, the straightforward approach is to make this a governed parameter of the VaultFactory. But currently, all the governed parameters are delegated on a per-VaultManager basis. Maybe mixing delegated with un-delegated is easy/straightforward, but if it's not...

creatorFacet method

One option is to have a method on the creatorFacet of VaultFactory for setting the period, and keep the creatorFacet in the bootstrap powers for use with big hammer governance (#4352 ).

the creatorFacet is returned at https://github.com/Agoric/agoric-sdk/blob/master/packages/run-protocol/bundles/install-on-chain.js#L335 but then dropped on the floor at https://github.com/Agoric/agoric-sdk/blob/master/packages/vats/src/core/econ-behaviors.js#L40 ; I expect to fix that as part of #4165 .

@mergify mergify bot closed this as completed in #4394 Feb 1, 2022
@Tartuffo Tartuffo added this to the Mainnet 1 milestone Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Economy OBSOLETE in favor of INTER-protocol enhancement New feature or request good first issue Good for newcomers Inter-protocol Overarching Inter Protocol restival to be done before RUN Protocol Purple Team festival
Projects
None yet
5 participants