Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(treasury): use liquidationMargin for maxDebt calculation #4163

Merged
merged 2 commits into from
Dec 13, 2021

Conversation

samsiegart
Copy link
Contributor

Fixes Agoric/dapp-treasury#48

I know there was some more discussion on this, but for now I think it's better for the vault to not fail every time when using the default collateralization percent. This is the way it worked previously.

Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough about what maxDebtFor is supposed to do to review this.

It seems to be used in adjustBalancesHook but I don't see exactly what that is supposed to do either.

@samsiegart samsiegart added the automerge:squash Automatically squash merge label Dec 13, 2021
@mergify mergify bot merged commit c749af8 into master Dec 13, 2021
@mergify mergify bot deleted the treasury-max-debt branch December 13, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:squash Automatically squash merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when creating vault with 150% collateralization
3 participants