-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document copyRecord guarantees #3955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. It really needs a compelling name, though, so I'll not go so far as to approve, but won't block other approvals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! One question: should this explanation also explain what a Structure is, and how to assert that? Amounts must be Structures (no promises). Maybe just a sentence explanation and link to information on structures?
This part is about to change again. I'll wait until it settles down. |
c8ee4a3
to
4398b4b
Compare
4398b4b
to
6b13a39
Compare
@jessysaurusrex I'm including you, because my intention is that, once we follow the advice on this page, that this page is helpful for reviewers auditing code using this kind of input validation.
In a peculiar way, this is a start on a semantics of our distributed object system. But it is inside out precisely to focus on the meaning of these checks as input validation.