Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Add dismiss option for dapp connections #3836

Merged
merged 3 commits into from
Sep 16, 2021

Conversation

samsiegart
Copy link
Contributor

@samsiegart samsiegart commented Sep 16, 2021

This of course doesn't work if you open your wallet in another browser, in which case you may be spammed with many dapps that are not enabled.

Issue #3793

@samsiegart samsiegart force-pushed the wallet-dismiss-request branch from 6578d8a to 44a8f8e Compare September 16, 2021 16:19
@samsiegart
Copy link
Contributor Author

Added a close button to each request, and made them persist until manually closed (with some slightly different rendering for their completed states):
image

Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

It's good to begin seeing the ways in which backend improvements will make your job easier.

@samsiegart samsiegart merged commit f193fa2 into master Sep 16, 2021
@samsiegart samsiegart deleted the wallet-dismiss-request branch September 16, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants