fix: more missing Fars. kill "this" #3746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warner
approved these changes
Aug 22, 2021
katelynsills
approved these changes
Aug 23, 2021
There was a problem hiding this comment.
I looked at everything but the SwingSet changes. Everything looks good. Once question about offerHandlers: will they be required in the near future to be marked with "Far"? If so, we have many more changes to make to the contracts (in a future PR), and in our user documentation.
erights
force-pushed
the
markm-more-missing-fars
branch
from
5b0ccc3 to
8430326
Compare
erights
added a commit
that referenced
this pull request
Aug 23, 2021
erights
added a commit
that referenced
this pull request
Aug 29, 2021
erights
added a commit
that referenced
this pull request
Sep 17, 2021
erights
added a commit
that referenced
this pull request
Sep 18, 2021
erights
added a commit
that referenced
this pull request
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #3743 , which beefs up Far to check that only passables go in and out. This PR is the changes so those Far checks pass, and that are good changes anyway.