Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cosmos-sdk "vesting" #3469

Closed
JimLarson opened this issue Jul 13, 2021 · 4 comments
Closed

Rename cosmos-sdk "vesting" #3469

JimLarson opened this issue Jul 13, 2021 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@JimLarson
Copy link
Contributor

What is the Problem Being Solved?

The term "vesting" describes a change of ownership over time and is subject to "clawback" of the unvested property. The cosmos-sdk vesting accounts more properly implement "lockup" - a release of restrictions over time but with the same ownership, and where locked tokens can still be used, e.g. for staking or liens, just not transferred.

This is a known and long-standing bug in cosmos-sdk.

Description of the Design

Rename "vest" and "vesting" throughout namespaces, filenames, command names, documentation, etc. Some conversions might be:

  • unvested --> locked
  • vested --> unlocked
  • vesting --> lockup

Might need to retain deprecated API entry points for compatibility for a while, including command-line tools.

Security Considerations

Test Plan

@JimLarson JimLarson added documentation Improvements or additions to documentation enhancement New feature or request Large labels Jul 13, 2021
@Tartuffo
Copy link
Contributor

Tartuffo commented Feb 4, 2022

@JimLarson Is this done?

@JimLarson
Copy link
Contributor Author

We never pulled the trigger on this, since it's such an extensive change.

We might be able to address this as part of upstreaming our clawback vesting work, depending on how large of a refactoring makes sense for the existing code.

Covered by Cosmos issue #10662

@ivanlei
Copy link
Contributor

ivanlei commented Feb 24, 2024

This is an antique plan lost to the sands of time.

@ivanlei ivanlei closed this as not planned Won't fix, can't repro, duplicate, stale Feb 24, 2024
@JimLarson
Copy link
Contributor Author

Coincidentally, yesterday they noted in the upstream Cosmos issue that this will be addressed in their next release. They are renaming "vesting" to "lockup". That wording might have come from our involvement in the Auth working group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants