Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a contract to rely on managed parameters (Governance) #3189

Closed
Chris-Hibbert opened this issue May 27, 2021 · 0 comments · Fixed by #3310 or #3448
Closed

Update a contract to rely on managed parameters (Governance) #3189

Chris-Hibbert opened this issue May 27, 2021 · 0 comments · Fixed by #3310 or #3448
Assignees
Labels
enhancement New feature or request Governance Governance

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

Make use of the managed parameters (#3186) by updating one contract (probably either AMM or Treasury) to convert its parameters to be externally managed.

@Chris-Hibbert Chris-Hibbert added enhancement New feature or request Small Governance Governance labels May 27, 2021
@Chris-Hibbert Chris-Hibbert added this to the Beta Phase 4: Governance milestone May 27, 2021
@Chris-Hibbert Chris-Hibbert self-assigned this May 27, 2021
@rowgraus rowgraus modified the milestones: Beta Phase 4: Governance, Testnet: Metering Phase Jul 28, 2021
@rowgraus rowgraus removed this from the Testnet: Metering Phase milestone Aug 12, 2021
@dckc dckc self-assigned this Sep 2, 2021
Chris-Hibbert added a commit that referenced this issue Sep 20, 2021
extract params to a separate file
integrate contract governance into treasury
swingset test for treasury governance

closes #3189
closes #3473
Chris-Hibbert added a commit that referenced this issue Oct 1, 2021
extract params to a separate file
integrate contract governance into treasury
swingset test for treasury governance

closes #3189
closes #3473
Chris-Hibbert added a commit that referenced this issue Oct 1, 2021
extract params to a separate file
integrate contract governance into treasury
swingset test for treasury governance

closes #3189
closes #3473
Chris-Hibbert added a commit that referenced this issue Oct 2, 2021
extract params to a separate file
integrate contract governance into treasury
swingset test for treasury governance

closes #3189
closes #3473
Chris-Hibbert added a commit that referenced this issue Oct 2, 2021
extract params to a separate file
integrate contract governance into treasury
swingset test for treasury governance

closes #3189
closes #3473
Chris-Hibbert added a commit that referenced this issue Oct 6, 2021
extract params to a separate file
integrate contract governance into treasury
swingset test for treasury governance

closes #3189
closes #3473
Chris-Hibbert added a commit that referenced this issue Oct 7, 2021
extract params to a separate file
integrate contract governance into treasury
swingset test for treasury governance

closes #3189
closes #3473
mergify bot added a commit that referenced this issue Oct 8, 2021
* feat!: use contractGovernor to govern Treasury using ParamManager

extract params to a separate file
integrate contract governance into treasury
swingset test for treasury governance

closes #3189
closes #3473

* chore: minor cleanups: drop extra logs, standardize asserts, tsc fix

* chore: improve typescript declarations

* feat: add noAction electorate for assurance of no governance changes

* chore: validate() in test checks the installations

* fix: import types.js into params so bundle is usable in tests

* fix: remove spurious distinction in naming of Liquidity keyword

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot added a commit that referenced this issue Oct 8, 2021
* feat!: use contractGovernor to govern Treasury using ParamManager

extract params to a separate file
integrate contract governance into treasury
swingset test for treasury governance

closes #3189
closes #3473

* chore: minor cleanups: drop extra logs, standardize asserts, tsc fix

* chore: improve typescript declarations

* feat: add noAction electorate for assurance of no governance changes

* chore: validate() in test checks the installations

* fix: import types.js into params so bundle is usable in tests

* feat!: add a claimsRegistrar based on attestations

Agents who can deposit an attestation payment will get the ability to vote that amount.
refactor common registrat code to a library
tests that BinaryBallotCounter can count these votes.

* chore: review sugestions: types, cleanups, comments

* chore: better type decls, capitalize handles

more handles have capitalized names than not.

Suggestions from #3932

* fix: remove spurious distinction in naming of Liquidity keyword

* fix: handle<'attestation'> ==>  Handle<'Attestation'>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Governance Governance
Projects
None yet
3 participants