-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(xs-worker): respect !managerOptions.metered #3078
Conversation
unrelated test failure in ci; for follow-up, see #3079
reproduced with
failed to reproduce with
|
b646e7d tests that we can increment the counter and just not compare it against a threshold |
7d39919
to
14c7393
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it'd be nice to have that extra test, but it's not a big deal.
Hm, how messy would it be to build startXSnap
with a spawn
that recorded the arguments in a retrievable side-something and then called the real spawn? Probably too messy.
On the contrary... a bit more ocap discipline doesn't look messy at all, to me. :) c885d23 |
... and use it to test that unmetered XS vats are spawned without the `-l` metering option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! hooray for ocaps
goal: fixes #3074
This doesn't have an automated test for the main change.
Ideally I'd thread an instrumented version of
spawn
that records the args for the test to check. Butspawn
is imported from ambient authority incontroller.js
rather than being passed explicitly, so it's not obvious how to do this.