Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not getting enhanced stack traces #2992

Closed
Chris-Hibbert opened this issue Apr 28, 2021 · 2 comments
Closed

Not getting enhanced stack traces #2992

Chris-Hibbert opened this issue Apr 28, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Chris-Hibbert
Copy link
Contributor

Describe the bug

In recent work on Zoe contracts, I've noticed that I'm getting lousy stack trace info, or none at all. My tests fail, but I have to manually set breakpoints and hunt around for the location that something went wrong. Among other things, I also see cases where I can step through ava test assertions, and verify that the test should fail, but the test continues running and fails for unrelated reasons sometime later.

To Reproduce

https://github.com/Agoric/agoric-sdk/pull/2966/files#diff-ef3d02b0104386935d4a26278647b501b495f2a9283fb5173a2b2f18f79cf672R975

This PR captures the state where I had the problem. @michaelfig pointed out that it's not rebased to master, which caused other problems, but shouldn't be related to the stack trace issues.

To see the issue, run test-newSwap-swap.js. There are console.log() calls on lines 975 and 997. the first is before an actual failure in tradeAndCheck that isn't reported until after the code passes the test on line 999 without complaint. Neither produces very much in the way of a stack.

Expected behavior

When a test fails and exceptions are thrown, we should see great error reports and helpful stack traces.

Platform Environment

  • what OS are you using? what version of Node.js?
    On MacOS. If relevant, I can look up the version later. I'm not at that machine now.

  • is there anything special/unusual about your platform?
    Nothing unusual.

  • what version of the Agoric-SDK are you using? (run git describe --tags --always)

@dckc
Copy link
Member

dckc commented Oct 13, 2021

@Chris-Hibbert Is this still a problem? I suspect it was fixed in #2578 but might have regressed somewhat with the introduction of endo zip archives.

@kriskowal this is probably a good one to check as part of #3899 .

@Chris-Hibbert
Copy link
Contributor Author

This does seem to be fixed. The stack traces I get now have all the info I'm interested in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants