Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): publish 2.17.2 #2896

Merged
merged 6 commits into from
Apr 17, 2021
Merged

chore(release): publish 2.17.2 #2896

merged 6 commits into from
Apr 17, 2021

Conversation

michaelfig
Copy link
Member

Packages that have NEWS.md updates

--- a/packages/cosmic-swingset/CHANGELOG.md
+++ b/packages/cosmic-swingset/CHANGELOG.md
@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.29.2](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2021-04-16)
+
+
+### Bug Fixes
+
+* harmonise fake-chain and actual chain genesis block height ([8903f3b](https://github.com/Agoric/agoric-sdk/commit/8903f3b861b9c1bb92e551875ff2ae020c11b00f))
+
+
+
+
+
 ## [0.29.1](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2021-04-14)
 
 

@michaelfig michaelfig added the tooling repo-wide infrastructure label Apr 16, 2021
@michaelfig michaelfig requested a review from warner April 16, 2021 02:01
@michaelfig michaelfig self-assigned this Apr 16, 2021
Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Strange how so many packages have their versions bumped even though the code didn't change. It looks like dependency cycles that involve devDependencies force every package to get revved.

@michaelfig michaelfig enabled auto-merge April 16, 2021 02:19
@michaelfig michaelfig disabled auto-merge April 16, 2021 22:30
@michaelfig
Copy link
Member Author

Hi @warner, turns out the CI on that PR failed (hung forever with the initial_height: "1" failure you saw). I've tested these changes with initial_height: "1", initial_height: "17", genesis_time: <now> and genesis_time: <now + 10 min>.

@michaelfig michaelfig merged commit 975521a into beta Apr 17, 2021
@michaelfig michaelfig deleted the release-20210416T015958 branch April 17, 2021 00:17
erights added a commit that referenced this pull request Apr 24, 2021
Part 2 of the removal of ibids. #2896 changed our code to no longer send ibids, but still understood received ibids to not break and near cross-version communications. More than a week after #2896 was merged, this PR removes the code for understanding them (except to give a more informative error if it sees one anyway). After this PR we should still be compatible with senders running code after #2896. But not earlier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling repo-wide infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants