Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn lint local vs remote inconsistency #2774

Closed
erights opened this issue Mar 31, 2021 · 1 comment
Closed

yarn lint local vs remote inconsistency #2774

erights opened this issue Mar 31, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@erights
Copy link
Member

erights commented Mar 31, 2021

#2773 is only a README change , and so is representative of master at that time. It's lint check succeeds under CI but locally fails with

$ cd packages/assert/
$ yarn lint
yarn run v1.22.5
$ yarn lint:types && yarn lint:eslint
$ tsc -p jsconfig.json
src/types.js:1:1 - error TS6200: Definitions of the following identifiers conflict with those in another file: BaseAssert, AssertMakeError, AssertFail, AssertEqual, AssertTypeofBigint, AssertTypeofBoolean, AssertTypeofFunction, AssertTypeofNumber, AssertTypeofObject, AssertTypeofString, AssertTypeofSymbol, AssertTypeofUndefined, AssertTypeof, AssertString, AssertNote, DetailsToken, Details, StringablePayload, AssertQuote, Raise, MakeAssert, DetailsTag, Assert

1 // @ts-check
  

  ../../../../endojs/endo/packages/ses/src/error/types.js:1:1
    1 // @ts-check
      
    Conflicts are in this file.

../../../../endojs/endo/packages/ses/src/error/types.js:1:1 - error TS6200: Definitions of the following identifiers conflict with those in another file: BaseAssert, AssertMakeError, AssertFail, AssertEqual, AssertTypeofBigint, AssertTypeofBoolean, AssertTypeofFunction, AssertTypeofNumber, AssertTypeofObject, AssertTypeofString, AssertTypeofSymbol, AssertTypeofUndefined, AssertTypeof, AssertString, AssertNote, DetailsToken, Details, StringablePayload, AssertQuote, Raise, MakeAssert, DetailsTag, Assert

1 // @ts-check
  

  src/types.js:1:1
    1 // @ts-check
      
    Conflicts are in this file.


Found 2 errors.

error Command failed with exit code 2.

To fix that failure while working on #2769 at 0346c2e I delete the redundant types.js file and change agoric-sdk's assert.js from importing it to instead saying

/// <reference types="ses"/>

This fixes the yarn lint error locally, but causes the lint check to fail under CI as seen at
https://github.com/Agoric/agoric-sdk/pull/2769/checks?check_run_id=2240480256
The failure is

Cannot find name 'Assert'.

which makes sense if CI cannot dereference

/// <reference types="ses"/>

but my local environment can. However, I have no idea where to look for that difference.

@erights erights added the bug Something isn't working label Mar 31, 2021
@erights
Copy link
Member Author

erights commented Apr 1, 2021

As @dtribble suggested, once I cleared all caches and rebuilt my world, this problem went away. The current state works both locally and under CI. Closing.

@erights erights closed this as completed Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant