Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xsnap error.code #2749

Closed
dckc opened this issue Mar 29, 2021 · 1 comment
Closed

xsnap error.code #2749

dckc opened this issue Mar 29, 2021 · 1 comment
Labels
enhancement New feature or request xsnap the XS execution tool

Comments

@dckc
Copy link
Member

dckc commented Mar 29, 2021

What is the Problem Being Solved?

The exit codes from xsnap sub-processes are somewhat hidden in error.message strings in the xsnap JS API.

noted in #2681 (review)

Description of the Design

add an error.code property

Security Considerations

?

Test Plan

update tests that check for message: /exited with code 7/

cc @kriskowal
@dckc dckc added the enhancement New feature or request label Mar 29, 2021
@dckc dckc mentioned this issue Mar 29, 2021
Merged
@dckc dckc added the xsnap the XS execution tool label May 3, 2021
@dckc
Copy link
Member Author

dckc commented May 6, 2021

fixed in db3daaa

@dckc dckc closed this as completed May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request xsnap the XS execution tool
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dckc