-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to depend on ses 0.12.5 #2718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hoorah for housecleaning!
f1fb8b2
to
fdae272
Compare
@dckc I have an approval from @FUDCo and I am mostly green no conflicts, and so almost ready to merge. However, I am getting one CI error from @michaelfig and @katelynsills I took you off the reviewers list. However, @katelynsills , for many of the test cases I changed, I think you wrote them, so you might want to take a look. It was semi-manual but purely mechanical so I'm reasonably confident that the test changes didn't break anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glanced through it, but looks good to me!
569f41e
to
a84d89c
Compare
I don't recognize these symptoms. Let me investigate a but more...
|
It seems to be tripping over...
odd: that code isn't new. when I change that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is causing the first zoe test:xs-unit
test to fail, which suggests it would make all of them fail.
When I try to skip test-bondingCurve.js
it still fails on the first test script, though in a different mysterious way:
# test script: test/unitTests/contractSupport/test-depositTo.js
Module level directives cause errors when bundled, 'use jessie' was ignored.
(TypeError#1)
TypeError#1: Cannot assign to read only property 'hasOwnProperty' of object '[object Object]'
at Generator.next (<anonymous>)
at runMicrotasks (<anonymous>)
a84d89c
to
9dea2eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed, we'll postpone the XS interaction for now
Changing to WIP Draft until CI errors dealt with.