Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zoe): add Far to periodObserver #2577

Merged
merged 2 commits into from
Mar 4, 2021
Merged

fix(zoe): add Far to periodObserver #2577

merged 2 commits into from
Mar 4, 2021

Conversation

warner
Copy link
Member

@warner warner commented Mar 4, 2021

refs #2018

@warner warner added the Zoe package: Zoe label Mar 4, 2021
@warner warner requested a review from Chris-Hibbert March 4, 2021 17:42
@warner
Copy link
Member Author

warner commented Mar 4, 2021

Until we get marshal's "reject unmarked pass-by-reference objects" behavior landed (which can't happen until we've gone through all our code and marked everything with Far), we'll be playing a catch-up game. I'm watching the tree for new harden({ methods.. }) changes and will submit PRs for Far-ing them.

Once we get that behavior landed, tests will fail if new code fails to use Far, which will make it a lot more obvious :).

@warner warner force-pushed the 2018-annotate-zoe-loan branch from 92a6feb to ae71d19 Compare March 4, 2021 21:50
@warner warner merged commit 4c07722 into master Mar 4, 2021
@warner warner deleted the 2018-annotate-zoe-loan branch March 4, 2021 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Zoe package: Zoe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants