Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vatParameters to setup() arguments, make comms starting ID configurable #2529

Closed
warner opened this issue Feb 24, 2021 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request SwingSet package: SwingSet

Comments

@warner
Copy link
Member

warner commented Feb 24, 2021

What is the Problem Being Solved?

While debugging unit tests that use multiple comms vats (e.g. test-message-patterns.js), it would be nice to make the two comms vats use different number ranges when allocating their remote object/promise IDs, so the wire messages are easier to distinguish. We can accomplish this by changing state.js to start from an ID provided in vatParameters (with a suitable default when it is not provided), but currently vatParameters don't make it into a comms vat, because the setup() form of vat creation does not include it.

The task is to change src/kernel/vatManager/manager-local.js to call setup(syscall, state, helpers, vatPowers, vatParameters) instead of the current setup(syscall, state, helpers, vatPowers).

Then, change the comms vat to pass a configuration value in from vatParameters into the state initialization code.

@FUDCo
Copy link
Contributor

FUDCo commented Mar 1, 2021

Closed by #2537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SwingSet package: SwingSet
Projects
None yet
Development

No branches or pull requests

2 participants