Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder for top-of-turn error logging #2163

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Conversation

erights
Copy link
Member

@erights erights commented Jan 4, 2021

Only a placeholder because this PR provides no mechanism to turn the option on by configuration. Rather, the only way to turn it on is editing the code. Without this edit, there is no change in behavior so there's nothing to test.

Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erights erights merged commit f0c257c into master Jan 5, 2021
@erights erights deleted the turn-top-errors branch January 5, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants