Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Dependency checker yarn argument order #2051

Merged
merged 1 commit into from
Nov 25, 2020
Merged

fix: Dependency checker yarn argument order #2051

merged 1 commit into from
Nov 25, 2020

Conversation

kriskowal
Copy link
Member

yarn check-dependencies consistently failed for me locally because I could find no version of yarn where the --silent suffix actually suppressed the yarn log messages. By adjusting the argument order, I was able to get it working locally.

@kriskowal kriskowal requested a review from michaelfig November 25, 2020 02:18
michaelfig
michaelfig approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!

@kriskowal kriskowal merged commit c90fb61 into master Nov 25, 2020
@kriskowal kriskowal deleted the kris-depcheck branch November 25, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelfig michaelfig michaelfig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kriskowal @michaelfig