Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop suppressing contract evaluation errors #1887

Merged
merged 2 commits into from
Oct 21, 2020
Merged

fix: stop suppressing contract evaluation errors #1887

merged 2 commits into from
Oct 21, 2020

Conversation

erights
Copy link
Member

@erights erights commented Oct 20, 2020 •
edited
Loading

The old code was suppressing Node's UnhandledPromiseRejectionWarning wrong. If importBundle(...) returned a promise that rejected, the .catch(() => {}) would fulfill the returned installation promise with undefined.

I caught this because another bug of mine was hard to track down, because it was producing a SyntaxError that this code was suppressing.

katelynsills
katelynsills approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@katelynsills katelynsills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@erights erights merged commit 96cd62f into master Oct 21, 2020
@erights erights deleted the stop-suppressing-errors branch October 21, 2020 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katelynsills katelynsills katelynsills approved these changes

@michaelfig michaelfig Awaiting requested review from michaelfig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erights @katelynsills